Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Kafka image upgrade #27094

Open
wants to merge 2 commits into
base: feat/changes-except-upgrade
Choose a base branch
from

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Dec 20, 2024

Problem

Changes

One of the found changed of 3.7.x is that for whatever reason rebalancing takes longer when a new consumer group comes up. This seems to mess with a few of our tests that assume it is basically instant. This doesn't seem to be an issue with existing consumer group rebalancing.

  • Updates some tests with simply bigger timeouts
  • Refactors a bunch of the plugin server tests to generally be more descriptive and reliable

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@benjackwhite benjackwhite changed the title chore: Kafka image upgrade wip: Kafka image upgrade Dec 20, 2024
@benjackwhite benjackwhite changed the base branch from master to feat/changes-except-upgrade December 27, 2024 10:41
@benjackwhite benjackwhite changed the title wip: Kafka image upgrade feat: Kafka image upgrade Jan 2, 2025
@benjackwhite benjackwhite requested a review from a team January 2, 2025 11:13
@benjackwhite benjackwhite marked this pull request as ready for review January 2, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants